Rosetta detection and support added #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vkormushkin
reviewed
Feb 21, 2022
| ${System.getHardwareInfo() ?: ""} | ||
| Using Rosetta 2: ${if (System.isUsingRosetta) "Yes" else "No"} |
There was a problem hiding this comment.
I think we should add a separate message with info level in case Rosetta is used and nothing if it is not.
BTW what are a possible consequences for the end user if rosetta is enabled? Are any changes in configuration required in that case?
There was a problem hiding this comment.
Agree, a separate info message makes more sense.
I thought it would be nice to know since at least you can't install anything using Homebrew under Rosetta. But as far as I remember, nothing too KMM-specific.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.