Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add language_info to kernel_info_reply #1

Merged
merged 2 commits into from
Aug 31, 2016
Merged

add language_info to kernel_info_reply #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e68b809
add language_info to kernel_info_reply
AndreyG Aug 27, 2016
e90d8af
README typo fix
AndreyG Aug 27, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ Alpha version. Tested only with jupyter 4.1.1 on OS X so far.

## Example

Example notebook output is [here](http://htmlpreview.github.com/?https://github.com/ligee/kotlin-jupyter/blob/master/samples/KotlinSample01.html). *(It is ported form [Gral](https://github.com/eseifert/gral)
Example notebook output is [here](http://htmlpreview.github.com/?https://github.com/ligee/kotlin-jupyter/blob/master/samples/KotlinSample01.html). *(It is ported from [Gral](https://github.com/eseifert/gral)
project's `ConvolutionExample.java`).*

The notebook itself is located in the `samples` folder.
Expand Down
3 changes: 2 additions & 1 deletion src/main/kotlin/org/jetbrains/kotlin/jupyter/ikotlin.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,8 @@ fun JupyterConnection.Socket.shellMessagesHandler(msg: Message, repl: ReplForJup
content = jsonObject(
"protocol_version" to protocolVersion,
"language" to "Kotlin",
"language_version" to KotlinVersion.VERSION
"language_version" to KotlinVersion.VERSION,
"language_info" to jsonObject("name" to "kotlin", "file_extension" to "kt")
)))
"history_request" ->
send(makeReplyMessage(msg, "history_reply",
Expand Down