Notebook API #99
Merged
Notebook API #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
altavir
reviewed
Sep 3, 2020
jupyter-lib/kotlin-jupyter-api/src/main/kotlin/org/jetbrains/kotlin/jupyter/api/api.kt
Outdated
Show resolved
Hide resolved
| } | ||
|
|
||
| interface ResultsAccessor { | ||
| operator fun get(i: Int): Any? |
There was a problem hiding this comment.
As far as I can understand this hold asynchronous results. I think it is worth using coroutines here.
jupyter-lib/kotlin-jupyter-api/src/main/kotlin/org/jetbrains/kotlin/jupyter/api/api.kt
Outdated
Show resolved
Hide resolved
jupyter-lib/kotlin-jupyter-api/src/main/kotlin/org/jetbrains/kotlin/jupyter/api/api.kt
Outdated
Show resolved
Hide resolved
...lib/kotlin-jupyter-api/src/main/kotlin/org/jetbrains/kotlin/jupyter/api/libraryConnection.kt
Outdated
Show resolved
Hide resolved
jupyter-lib/kotlin-jupyter-api/src/main/kotlin/org/jetbrains/kotlin/jupyter/api/results.kt
Outdated
Show resolved
Hide resolved
ileasile
force-pushed
the
notebook-api
branch
2 times, most recently
from
776b775 to
9bb51cb
Compare
Closed
ileasile
force-pushed
the
notebook-api
branch
2 times, most recently
from
334178a to
1dd527c
Compare
ileasile
force-pushed
the
notebook-api
branch
4 times, most recently
from
f3d1a44 to
863e60d
Compare
ileasile
force-pushed
the
notebook-api
branch
7 times, most recently
from
15d114f to
cc43a4b
Compare
ileasile
force-pushed
the
notebook-api
branch
10 times, most recently
from
03acc4a to
a31f4d1
Compare
ileasile
force-pushed
the
notebook-api
branch
3 times, most recently
from
8bb119a to
8837bb4
Compare
Currently not working because of https://youtrack.jetbrains.com/issue/KT-44580
…into abstract method
…nd 'repositories' methods
ileasile
force-pushed
the
notebook-api
branch
from
f39e3c8 to
251ed4c
Compare
ileasile
force-pushed
the
notebook-api
branch
4 times, most recently
from
0101278 to
e61fccd
Compare
ileasile
force-pushed
the
notebook-api
branch
from
e61fccd to
13e62d1
Compare
ileasile
force-pushed
the
notebook-api
branch
from
05250f0 to
c047191
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds notebook API which is published as a separate artifact and may be used with any Kotlin library to integrate it with this kernel.
Some highlights:
notebookproperty is now availible in every cell, and it exposes the API. You may define, say,fun f(nb: Notebook<*>)and then call it in the notebook likef(notebook)Notebookinterface gives an access to cells and execution resultsCodeCellgives an access to code, streams and results of a given cellRenderableinterface, once implemented by your custom class, makes it renderableDisplayResultinterface is a "final" representation of your objects to be displayed withdisplay_datanotebook.host.updateDisplayfunctionRelates to #20, #76, #88, #78