Add explicit module-info for JPMS compatibility #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # atomicfu-transformer/src/main/kotlin/kotlinx/atomicfu/transformer/AtomicFUTransformer.kt
|
This project consists of only 1 published runtime JAR, similar to Note: I also reverted the ASM API change since it is already upgraded to |
There was a problem hiding this comment.
Thanks a lot for your work! I've read the review of JPMS support for kotlinx-datetime as the structure here is pretty much the same. Looks good to me.
I've asked @ilya-g to take the final look before merge.
mvicsokolova
approved these changes
Nov 16, 2021
ilya-g
approved these changes
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Largely based on Kotlin/kotlinx.serialization#1624 and the review comments there.
Note: I did have to update the ASM API version to
ASM6for the build to succeed..