Update gradle to 7.3 #300
Merged
Update gradle to 7.3 #300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvicsokolova
force-pushed
the
update-gradle
branch
from
14490cf to
cf7d856
Compare
mvicsokolova
commented
May 4, 2023
atomicfu-maven-plugin/build.gradle
Outdated
| } | ||
|
|
||
| def pomFile = file("$buildDir/pom.xml") | ||
| def pomFile = file("$buildDir/publications/maven/pom-default.xml") |
There was a problem hiding this comment.
Now I rely on the path of the pom file, created with generatePomFileForMavenPublication. Is it ok or I can set the custom path somehow?
There was a problem hiding this comment.
Better to use related task destination, something like this:
def pomFile = tasks.named("generatePomFileForMainPublication", GenerateMavenPom).map { it.get().destintion() }.get()
Tapchicoma
approved these changes
May 4, 2023
atomicfu/build.gradle
Outdated
| @@ -305,15 +306,16 @@ tasks.withType(Test) { | |||
|
|
|||
| task compileJavaModuleInfo(type: JavaCompile) { | |||
| def moduleName = "kotlinx.atomicfu" // this module's name | |||
| def compileKotlinJvm = kotlin.targets["jvm"].compilations["main"].compileKotlinTask | |||
| def compilation = kotlin.targets["jvm"].compilations["main"] | |||
| def compileKotlinTask = compilation.compileTaskProvider.get() as KotlinCompile | |||
There was a problem hiding this comment.
Nit: would be nice to not trigger compile task eager creation and just cast to TaskProvider<KotlinJvmCompile>. But it is completely optional in this PR and it could be fixed later by me.
atomicfu-maven-plugin/build.gradle
Outdated
| } | ||
|
|
||
| def pomFile = file("$buildDir/pom.xml") | ||
| def pomFile = file("$buildDir/publications/maven/pom-default.xml") |
There was a problem hiding this comment.
Better to use related task destination, something like this:
def pomFile = tasks.named("generatePomFileForMainPublication", GenerateMavenPom).map { it.get().destintion() }.get()
Co-authored-by: Yahor Berdnikau <yahor.berdnikau@jetbrains.com>
woainikk
pushed a commit
that referenced
this pull request
Jun 26, 2023
* Migrated from Gradle 6 to 7 * Updated atomicfu-maven-plugin publication (cherry picked from commit 0fac729)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.