-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build config/build scans and build cache #451
Conversation
55eb001
to
68e5567
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These utils are only used in gradle-build-scan.settings.gradle.kts
- maybe they should be moved into the same file?
Alternatively, I think a more descriptive name would be nice. What about BuildScanProperties.kt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would leave it as is for the future, if we have some shared logic, it could be placed in Utils.kt
file
build-settings-logic/src/main/kotlin/gradle-build-scan.settings.gradle.kts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Exciting to see the build config shaping up really well.
Co-authored-by: Adam <152864218+adam-enko@users.noreply.github.com>
Co-authored-by: Adam <152864218+adam-enko@users.noreply.github.com>
Co-authored-by: Adam <152864218+adam-enko@users.noreply.github.com>
…s.gradle.kts Co-authored-by: Adam <152864218+adam-enko@users.noreply.github.com>
Looks great, thank you!) |
In this commit added: