Mark runtime APIs that are unintentionally public with @InternalAPI #205
Conversation
| final fun valueOf(kotlin/String): kotlinx.benchmark/NativeFork // kotlinx.benchmark/NativeFork.valueOf|valueOf#static(kotlin.String){}[0] | ||
| final fun values(): kotlin/Array<kotlinx.benchmark/NativeFork> // kotlinx.benchmark/NativeFork.values|values#static(){}[0] | ||
| final val entries // kotlinx.benchmark/NativeFork.entries|#static{}entries[0] | ||
| final fun <get-entries>(): kotlin.enums/EnumEntries<kotlinx.benchmark/NativeFork> // kotlinx.benchmark/NativeFork.entries.<get-entries>|<get-entries>#static(){}[0] | ||
| } | ||
| // Targets: [js.jsIr, wasmJs] | ||
| final class kotlinx.benchmark/Blackhole : kotlinx.benchmark/CommonBlackhole { // kotlinx.benchmark/Blackhole|null[0] |
There was a problem hiding this comment.
It's not directly related to the change, but as soon as CommonBlackhole is hidden, there will be no info about Blackhole's members in the dump.
There's a request to overcome that problem on BCV side and dump all members inherited from the private API (Kotlin/binary-compatibility-validator#217), but here, I believe, the better solution would be to introduce a source set descending from commonMain and shared between both jsMain and wasmJsMain source sets and actualize the Blackhole there (kotlinx-io use that approach for implementing nodeJs-dependent classes for js and wasmJs: https://github.com/Kotlin/kotlinx-io/blob/c2d52202984f610054f21fd77def42e6f554bb70/build-logic/src/main/kotlin/kotlinx/io/conventions/kotlinx-io-multiplatform.gradle.kts#L84)
There was a problem hiding this comment.
Thanks for pointing out. It turns out CommonBlackhole can't be properly made internal. Because in Kotlin public classes can't inherit from internal classes. I have created a separate PR for sharing Blackhole implementation btw Js and WasmJs, so that CommonBlackhole could be dropped later: #207
runtime/commonMain/src/kotlinx/benchmark/internal/KotlinxBenchmarkPluginInternalApi.kt
Outdated
Show resolved
Hide resolved
…markPluginInternalApi.kt Co-authored-by: Adam <152864218+adam-enko@users.noreply.github.com>
A follow-up to #194