Allow ArgType.Choice for Enums to limit list of values #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Makes it easier to use a subset of enum values for a certain enum as a Choice ArgType
ilya-g
requested changes
Feb 15, 2023
core/commonMain/src/ArgType.kt
Outdated
| @@ -75,11 +75,12 @@ abstract class ArgType<T : Any>(val hasParameter: kotlin.Boolean) { | |||
| * Helper for arguments that have limited set of possible values represented as enumeration constants. | |||
| */ | |||
| inline fun <reified T : Enum<T>> Choice( | |||
| values: List<T> = enumValues<T>().toList(), | |||
There was a problem hiding this comment.
In the other similar overload such list is called choices
This makes it easier to use the commands, cause it will print the help text when you set printHelpOnEmptyArgs = true
Allow passing printHelpOnEmptyArgs to ArgParser
Use choices, update toVariant
I agree, but dont have the time/resources todo that now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it easier to use a subset of enum values for a certain enum as a Choice ArgType