Bump Kotlin to 1.6.0 and remove ExperimentalTime #161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-g
approved these changes
Dec 10, 2021
| @@ -43,8 +44,8 @@ public actual class Instant internal constructor(internal val value: jtInstant) | |||
| public actual operator fun minus(duration: Duration): Instant = plus(-duration) | |||
|
|
|||
| public actual operator fun minus(other: Instant): Duration = | |||
| Duration.seconds(this.value.epochSecond - other.value.epochSecond) + // won't overflow given the instant bounds | |||
| Duration.nanoseconds(this.value.nano - other.value.nano) | |||
| (this.value.epochSecond - other.value.epochSecond).seconds + // won't overflow given the instant bounds | |||
There was a problem hiding this comment.
Minor: I'd probably use in such cases a more verbose .toDuration(DurationUnit.SECONDS) to sound less tautological.
There was a problem hiding this comment.
Tried this and didn't like the result, looked to me as much more cumbersome than both Duration.seconds(...) and .seconds, so the intent is obscured. .seconds is not pretty, but very obvious.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #156
Supersedes #159