Fix adding small Duration to large Instant on JS and Native
#264
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a positive Duration < 1 second to an Instant far in the future for which the addition implementation overflows and throws an exception, the catch blocks would only check if the seconds component of the Duration is > 0. However since the Duration is < 1 second, the seconds component is not > 0 and Instant.MIN is returned instead of Instant.MAX. This was fixed by replacing the check against the seconds component of the Duration with a check against the whole Duration like it was already done in the JVM implementation. See Kotlin#263
ilya-g
approved these changes
Mar 29, 2023
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a positive
Duration< 1 second to anInstantfar in the future for which the addition implementation overflows and throws an exception, thecatchblocks would only check if thesecondscomponent of theDurationis> 0. However since theDurationis < 1 second, thesecondscomponent is not> 0andInstant.MINis returned instead ofInstant.MAX.This was fixed by replacing the check against the seconds component of the
Durationwith a check against the wholeDurationlike it was already done in the JVM implementation.fixes #263