Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Kotlin version to 1.9.21 #318

Merged
merged 8 commits into from
Nov 24, 2023
Merged

Update Kotlin version to 1.9.21 #318

merged 8 commits into from
Nov 24, 2023

Conversation

FenstonSingel
Copy link
Contributor

No description provided.

@FenstonSingel FenstonSingel self-assigned this Nov 16, 2023
ilya-g
ilya-g reviewed Nov 17, 2023
View reviewed changes
gradle.properties Outdated Show resolved Hide resolved
ilya-g
ilya-g approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@ilya-g ilya-g left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash commits before merging.
Also note that it's just "Kotlin version", not "Kotlin release version"

@ilya-g ilya-g mentioned this pull request Nov 17, 2023
Closed
@ilya-g
Copy link
Member

ilya-g commented Nov 17, 2023

Also it would be better to wait a bit for Kotlin 1.9.21

@FenstonSingel FenstonSingel changed the title Update Kotlin release version to 1.9.20 Update Kotlin version to 1.9.20 Nov 18, 2023
@FenstonSingel
Copy link
Contributor Author

Force-pushed an updated intermediate state of the branch.
I will get back to this PR to finalize it after 1.9.21's release.

Please squash commits before merging.

Sure thing. GitHub's "Squash and merge" will do the trick, right?

@FenstonSingel FenstonSingel changed the title Update Kotlin version to 1.9.20 Update Kotlin version to 1.9.21 Nov 24, 2023
@FenstonSingel
Copy link
Contributor Author

Kotlin version changed from 1.9.20 to 1.9.21.
PR should be ready for further review and merging.

@FenstonSingel FenstonSingel requested review from dkhalanskyjb and removed request for qwwdfsad November 24, 2023 14:07
@dkhalanskyjb dkhalanskyjb merged commit f97034f into master Nov 24, 2023
1 check passed
@FenstonSingel FenstonSingel deleted the ruban/update-to-kotlin-1.9.20 branch November 24, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilya-g ilya-g ilya-g approved these changes

@dkhalanskyjb dkhalanskyjb Awaiting requested review from dkhalanskyjb

Assignees

@FenstonSingel FenstonSingel

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FenstonSingel @ilya-g @dkhalanskyjb