Implement parsing and formatting for Instant as separate functions #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
force-pushed
the
instant-separate-formatting
branch
from
71fc711
to
fd78536
Compare
ilya-g
reviewed
Oct 30, 2024
core/native/src/Instant.kt
Outdated
Comment on lines
173
to
175
| total += (y + 3) / 4 - (y + 99) / 100 + (y + 399) / 400 | ||
| } else { | ||
| total -= y / -4 - y / -100 + y / -400 |
There was a problem hiding this comment.
Looks like a case for ceilDiv in stdlib :)
dkhalanskyjb
force-pushed
the
instant-separate-formatting
branch
from
fd78536
to
019c71b
Compare
dkhalanskyjb
changed the title
dkhalanskyjb
commented
Nov 7, 2024
Comment on lines
+401
to
+409
| private fun parseInstant(isoString: String): Instant { | ||
| // return Instant.parse(isoString) | ||
| return parseIso(isoString) | ||
| } | ||
|
|
||
| private fun displayInstant(instant: Instant): String { | ||
| // return instant.toString() | ||
| return formatIso(instant) | ||
| } |
There was a problem hiding this comment.
@qurbonzoda, here's the logic behind this PR: the newly-added formatIso can replace toString, and the newly-added parseIso can replace Instant.parse in the case when no specific format is passed (which is the only case supported by `kotlin.time.Instant).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement parsing and formatting of ISO strings for instant values separately from the rest of the library.
A stage of fixing #382
This is a draft PR because we probably don't need to actually merge it into the datetime library. However, the code is already written and can be reviewed.