Support JS IR target #151
Support JS IR target #151
Conversation
fzhinkin
force-pushed
the
prototype-preview-js-src-set
branch
from
ce62175 to
1806ed0
Compare
|
|
||
| import kotlinx.io.internal.commonAsUtf8ToByteArray | ||
|
|
||
| internal actual fun String.asUtf8ToByteArray(): ByteArray = commonAsUtf8ToByteArray() |
There was a problem hiding this comment.
minor: can't we just use String.encodeToByteArray(): ByteArray on all platforms?
There was a problem hiding this comment.
It (encodeToByteArray) behaves differently on JVM and Native when encoding invalid code points (and I'll revisit its usage in ByteString's).
|
|
||
| package kotlinx.io | ||
|
|
||
| internal actual object SegmentPool { |
There was a problem hiding this comment.
question: will JS/Native have pooling some day? If so may be it's better to create an issue for this. Or this will be implemented in scope of #135/different segment types?
There was a problem hiding this comment.
It will be considered after #135 (I expect to see the performance improvement on Native w/ enabled pooling, but I didn't measure it yet).
| } | ||
| val bytesToRead = minOf(byteCount, (len - offset)) | ||
| for (i in 0 until bytesToRead) { | ||
| sink.writeByte(buffer.readInt8(offset++) as Byte) |
There was a problem hiding this comment.
minor: we can do bulk copy here: https://nodejs.org/api/buffer.html#bufcopytarget-targetstart-sourcestart-sourceend
There was a problem hiding this comment.
Buffer::copy expects Buffer or UInt8Array as the destination, and Segment's backing array (Segment::data) is an instance of Int8Array.
I think the issue could be addressed later, after #135
Supported JS-IR target.
Closes #141