Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the type of bytestring module dependency to api #171

Merged
merged 1 commit into from
Jul 11, 2023
Merged

Change the type of bytestring module dependency to api #171

merged 1 commit into from
Jul 11, 2023

Conversation

fzhinkin
Copy link
Collaborator

Fixes #169

@fzhinkin fzhinkin added the bug label Jul 10, 2023
@fzhinkin fzhinkin self-assigned this Jul 10, 2023
@fzhinkin fzhinkin marked this pull request as ready for review July 10, 2023 11:07
@fzhinkin fzhinkin requested review from shanshin and ilya-g July 10, 2023 11:08
@fzhinkin
Copy link
Collaborator Author

Also created a project covering the issue (https://github.com/fzhinkin/kotlinx-io-release-smoke-test), not sure if it should be a part of the kotlinx-io repo though (mainly because of the maven-related subproject).

@fzhinkin fzhinkin merged commit 07be667 into master Jul 11, 2023
@fzhinkin fzhinkin deleted the fix-bytestring-dep-type branch July 11, 2023 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanshin shanshin shanshin approved these changes

@ilya-g ilya-g Awaiting requested review from ilya-g

Assignees

@fzhinkin fzhinkin

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bytestring dependency is implementation
2 participants
@fzhinkin @shanshin