Support path resolution #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzhinkin
force-pushed
the
fs-implement-resolve
branch
from
0430ebf to
52b7387
Compare
shanshin
reviewed
Oct 16, 2023
| } | ||
|
|
||
| @Test | ||
| fun resolve() { |
There was a problem hiding this comment.
I think I need to add more tests: to check for an exception if the path does not exist, to check for an absolute path, etc.
There was a problem hiding this comment.
Added the test for absolute path, all other cases are already there.
It would be nice to test symlink resolution, but we don't have an API for links yet.
shanshin
reviewed
Oct 18, 2023
| val root = createTempPath() | ||
| SystemFileSystem.createDirectories(Path(root, "a", "b")) | ||
| val tgt = Path(root, "c", "d") | ||
| SystemFileSystem.createDirectories(tgt) | ||
|
|
||
| val src = Path(root, "a", "..", "a", ".", "b", "..", "..", "c", ".", "d") | ||
| try { | ||
| // root/a/../a/./b/../../c/./d -> root/c/d |
shanshin
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #223