Enable WasmWasi target #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added WasmWasi target sharing the same source code with WasmJs target for now. Closes #234
ilya-g
reviewed
Nov 23, 2023
build-logic/src/main/kotlin/kotlinx/io/conventions/kotlinx-io-multiplatform.gradle.kts
Outdated
Show resolved
Hide resolved
ilya-g
approved these changes
Dec 1, 2023
lppedd
reviewed
Dec 22, 2023
| @OptIn(org.jetbrains.kotlin.gradle.targets.js.dsl.ExperimentalWasmDsl::class) | ||
| wasmWasi { | ||
| nodejs() | ||
| binaries.executable() |
There was a problem hiding this comment.
@fzhinkin sorry for bothering again, can I ask why you explicitly selected an executable binary?
Wouldn't this be done by consumers of the library?
There was a problem hiding this comment.
@lppedd thanks for pointing to this! You're absolutely right, it should be done by consumers and there's absolutely no sense in specifying it for the library. I'll remove it.
fzhinkin
added a commit
that referenced
this pull request
Jan 4, 2024
Added WasmWasi target sharing the same source code with WasmJs target for now. Closes #234
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added WasmWasi target sharing the same source code with WasmJs target for now.
Closes #234