Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align file sink and source creation behavior across targets #252

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Align file sink and source creation behavior across targets #252

merged 4 commits into from
Jan 24, 2024

Commits on Jan 15, 2024

  1. JS: open a file on the FileSink construction 

    That ensures that even if nothing was written, a new empty file will be created on close.

Fixes #251
    @fzhinkin
    fzhinkin committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    3b7b53b View commit details
    Browse the repository at this point in the history

  2. JS: check file existence when creating the FileSource 

    Align the behavior across all targets
    @fzhinkin
    fzhinkin committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    3d0b3e0 View commit details
    Browse the repository at this point in the history

  3. Cleanup

    @fzhinkin
    fzhinkin committed Jan 15, 2024
    Configuration menu
    Copy the full SHA
    3820e5c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2024

  1. Fixed close behavior and exceptions messages

    @fzhinkin
    fzhinkin committed Jan 22, 2024
    Configuration menu
    Copy the full SHA
    20d6498 View commit details
    Browse the repository at this point in the history