Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ByteString to/from NSData conversions #384

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Support ByteString to/from NSData conversions #384

merged 2 commits into from
Sep 17, 2024

Conversation

fzhinkin
Copy link
Collaborator

@fzhinkin fzhinkin commented Sep 4, 2024 •
edited
Loading

Open questions:

  • Should we also support creation of NSData for ByteString's subrange (and vice versa)?
    fun ByteString.toNSData(fromIndex: Int = 0, toIndex = length)
  • Perhaps, we should also support reading and writing NSData from Sink/Source?

Closes #266

@fzhinkin fzhinkin mentioned this pull request Sep 4, 2024
Closed
@fzhinkin fzhinkin marked this pull request as ready for review September 6, 2024 13:28
@fzhinkin fzhinkin linked an issue Sep 6, 2024 that may be closed by this pull request
Add NSData.toByteString() and ByteString.toNSData() for Apple targets #266
Closed
@fzhinkin fzhinkin requested a review from shanshin September 6, 2024 13:28
@fzhinkin fzhinkin merged commit da34f10 into develop Sep 17, 2024
1 check passed
@fzhinkin fzhinkin deleted the bytestring-nsdata branch September 17, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shanshin shanshin shanshin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add NSData.toByteString() and ByteString.toNSData() for Apple targets
2 participants
@fzhinkin @shanshin