Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not write TOC when running knitCheck #36

Merged
merged 2 commits into from
Apr 9, 2022

Conversation

thumannw
Copy link
Contributor

@thumannw thumannw commented Feb 2, 2022

The task knitCheck promises to not modify any files. However, TOCs are written when the TOC directives are used. This simple fix aligns the behavior with the other Knit features: knitCheck does not write TOCs but raises an error if they are not up-to-date.

@qwwdfsad qwwdfsad self-requested a review April 9, 2022 14:17
Copy link
Contributor

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@qwwdfsad qwwdfsad merged commit 1474435 into Kotlin:main Apr 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants