Performed code refactoring #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
approved these changes
Jun 5, 2023
| plugins { | ||
| kotlin("jvm") version kotlinVersion | ||
| kotlin("jvm") version embeddedKotlinVersion |
There was a problem hiding this comment.
Is embeddedKotlinVersion a variable provided by Gradle itself? I didn't notice its definition
There was a problem hiding this comment.
| include(":kover-gradle-plugin") |
There was a problem hiding this comment.
Also, I haven't noticed any changes in publication-related functionality. Are you sure root project won't be published accidentally?
There was a problem hiding this comment.
Yes, the root project cannot be published, because the maven-publish plugin is not applied in it and, accordingly, there are no publishing tasks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the increase in the number of artifacts and dependencies, in order to avoid errors in the future, it became necessary to change the structure of subprojects and add a version catalog.
Gradle plugin is now a subproject, on a par with the CLI and others.
Also implemented is getting rid of buildSrc as an outdated approach in favor of composite assemblies.