Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose reportDir property in KoverHtmlReport interface #591

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Expose reportDir property in KoverHtmlReport interface #591

merged 1 commit into from
Apr 2, 2024

Conversation

shanshin
Copy link
Collaborator

if there is a need to analyze the HTML report after it is generated, or if you need to improve the report (for example, by editing CSS styles), you need to know the directory of each report. Currently, it is not possible to easily link a specific report generation task and a directory.

Resolves #590

@shanshin
Expose reportDir property in KoverHtmlReport interface
e678ad0 
if there is a need to analyze the HTML report after it is generated, or if you need to improve the report (for example, by editing CSS styles), you need to know the directory of each report.
Currently, it is not possible to easily link a specific report generation task and a directory.

Resolves #590
@shanshin shanshin requested a review from sandwwraith March 29, 2024 12:12
sandwwraith
sandwwraith approved these changes Apr 2, 2024
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why KoverHtmlTaskConfig.htmlDir is not suitable here?

@shanshin
Copy link
Collaborator Author

shanshin commented Apr 2, 2024 •
edited
Loading

Why KoverHtmlTaskConfig.htmlDir is not suitable here?

because in this case, to add the doFirst action to the task, we first need to add the variantName property to KoverReport interface (to match variant), and then redo kover.reports.variant(task.variantName) so that you can work with it as an object and call it during task execution - this method requires more effort and gives exactly the same result.

@shanshin shanshin merged commit 2e6efc8 into main Apr 2, 2024
1 check passed
@shanshin shanshin deleted the html-report-property branch April 2, 2024 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose reportDir property in KoverHtmlReport interface
2 participants
@shanshin @sandwwraith