Skip to content

Conversation

Jozott00
Copy link
Collaborator

Subsystem
Protobuf

Problem Description
Proto2 conformance tests didn't compile and only proto3 and proto3 editions tests were activated.

Solution
This PR fixes all compilation errors and activate all conformance tests.
Additionally the ConformanceTest test runner now excludes all JSON related tests, as JSON is currently not supported.

The current conformance results are (JSON tests excluded):

=== Conformance Test Results (filtered) ===
Total baseline tests (filtered):   2805
[+] Passed tests:                  2790
[-] Failed tests:                  15

The 15 failing tests are:

  1. Missing unknown fields in response message (we currently always skip unknown fields)
FAILED: 'Required.Proto2.ProtobufInput.UnknownOrdering.ProtobufOutput' with: Unknown field mismatch
FAILED: 'Required.Proto2.ProtobufInput.UnknownVarint.ProtobufOutput' with: Output was not equivalent to reference message: Expect: \250\037\001, but got:
FAILED: 'Required.Proto3.ProtobufInput.UnknownOrdering.ProtobufOutput' with: Unknown field mismatch
FAILED: 'Required.Proto3.ProtobufInput.UnknownVarint.ProtobufOutput' with: Output was not equivalent to reference message: Expect: \250\037\001, but got:
FAILED: 'Required.Editions_Proto2.ProtobufInput.UnknownOrdering.ProtobufOutput' with: Unknown field mismatch
FAILED: 'Required.Editions_Proto2.ProtobufInput.UnknownVarint.ProtobufOutput' with: Output was not equivalent to reference message: Expect: \250\037\001, but got:
FAILED: 'Required.Editions_Proto3.ProtobufInput.UnknownOrdering.ProtobufOutput' with: Unknown field mismatch
FAILED: 'Required.Editions_Proto3.ProtobufInput.UnknownVarint.ProtobufOutput' with: Output was not equivalent to reference message: Expect: \250\037\001, but got:
  1. Missing support for extensions and option message_set_wire_format
FAILED: 'Required.Editions.ProtobufInput.ValidDelimitedExtension.GroupLike.ProtobufOutput' with: Output was not equivalent to reference message: deleted: (protobuf_test_messages.editions.groupliketype): { c: 99 }
FAILED: 'Required.Editions.ProtobufInput.ValidDelimitedExtension.NotGroupLike.ProtobufOutput' with: Output was not equivalent to reference message: deleted: (protobuf_test_messages.editions.delimited_ext): { c: 99 }
FAILED: 'Required.Proto2.ProtobufInput.MessageSetEncoding.UnknownExtension.ProtobufOutput' with: Output was not equivalent to reference message: deleted: message_set_correct.4135300[0]: "\000c"
FAILED: 'Recommended.Proto2.ProtobufInput.ValidMessageSetEncoding.SubmessageEncoding.NotUnknown.ProtobufOutput' with: Output was not equivalent to reference message: deleted: message_set_correct.(protobuf_test_messages.proto2.TestAllTypesProto2.E
FAILED: 'Recommended.Proto2.ProtobufInput.ValidMessageSetEncoding.SubmessageEncoding.ProtobufOutput' with: Output was not equivalent to reference message: deleted: message_set_correct.(protobuf_test_messages.proto2.TestAllTypesProto2.M
FAILED: 'Required.Proto2.ProtobufInput.ValidMessageSetEncoding.OutOfOrderGroupsEntries.ProtobufOutput' with: Output was not equivalent to reference message: deleted: message_set_correct.(protobuf_test_messages.proto2.TestAllTypesProto2.M
FAILED: 'Required.Proto2.ProtobufInput.ValidMessageSetEncoding.ProtobufOutput' with: Output was not equivalent to reference message: deleted: message_set_correct.(protobuf_test_messages.proto2.TestAllTypesProto2.M

@Jozott00 Jozott00 force-pushed the pb/fix-conformance-tests branch from 6d098b9 to 6c387fc Compare September 10, 2025 14:20
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
@Jozott00 Jozott00 force-pushed the pb/fix-conformance-tests branch from 6c387fc to 156eae8 Compare September 10, 2025 14:22
@Jozott00 Jozott00 marked this pull request as ready for review September 10, 2025 14:23
@Jozott00 Jozott00 requested a review from Mr3zee September 10, 2025 14:23
@Jozott00 Jozott00 added the feature New feature or request label Sep 10, 2025
@Jozott00 Jozott00 self-assigned this Sep 10, 2025
Copy link
Member

@Mr3zee Mr3zee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah!

Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
Signed-off-by: Johannes Zottele <official@johannes-zottele.at>
@Jozott00 Jozott00 merged commit 78da810 into grpc-common Sep 10, 2025
10 of 11 checks passed
@Jozott00 Jozott00 deleted the pb/fix-conformance-tests branch September 11, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants