Skip to content

Flow.flattenMerge benchmark #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Parent: Redispatch local tasks before thread parking in runBlocking
merged 12 commits into from
Dec 26, 2019
Merged

Flow.flattenMerge benchmark #1464

merged 12 commits into from
Dec 26, 2019

Conversation

@fmixing
Copy link
Contributor

@fmixing fmixing commented Aug 23, 2019 •
edited by ndkoval
Loading

This benchmark measures the performance of both Flatten.flattenMerge and Semaphore performance.

@fmixing fmixing requested a review from ndkoval August 23, 2019 10:45
@fmixing fmixing changed the base branch from master to develop August 23, 2019 10:46
ndkoval
ndkoval requested changes Aug 23, 2019
View reviewed changes
ndkoval
ndkoval requested changes Aug 24, 2019
View reviewed changes
ndkoval
ndkoval requested changes Sep 12, 2019
View reviewed changes
Copy link
Member

@ndkoval ndkoval left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! However, it requires some minor changes. Please see the comments.

Please, resolve conversations when they are resolved, and send pull requests for review here on GitHub when you want this.

@ndkoval ndkoval changed the title Flatten flow bench Flow.flattenMerge benchmark Sep 12, 2019
@fmixing fmixing requested a review from ndkoval September 18, 2019 11:33
qwwdfsad
qwwdfsad requested changes Sep 20, 2019
View reviewed changes
ndkoval
ndkoval requested changes Sep 23, 2019
View reviewed changes
@fmixing fmixing requested a review from ndkoval September 24, 2019 13:59
@fmixing fmixing force-pushed the flatten-flow-bench branch from c0421c8 to f849d00 Compare November 9, 2019 10:41
@fmixing fmixing requested a review from qwwdfsad November 9, 2019 10:41
qwwdfsad
qwwdfsad requested changes Nov 21, 2019
View reviewed changes
benchmarks/src/main/kotlin/BenchmarkUtils.kt Outdated

import java.util.concurrent.ThreadLocalRandom

fun doGeomDistrWork(work: Int) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you verified that this function actually behaves like a geometric distribution when it is stressed on JVM?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested this function on different means, and created histograms of execution times. You can see the code here https://gist.github.com/fmixing/badbfc029e154486c8766ab9cc70a2a6
Geom distr benchmark

@fmixing fmixing requested review from ndkoval and qwwdfsad December 16, 2019 16:02
ndkoval
ndkoval requested changes Dec 16, 2019
View reviewed changes
@fmixing fmixing requested a review from ndkoval December 16, 2019 21:46
ndkoval
ndkoval approved these changes Dec 21, 2019
View reviewed changes
Copy link
Member

@ndkoval ndkoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@qwwdfsad qwwdfsad merged commit fe15b6d into develop Dec 26, 2019
@qwwdfsad qwwdfsad deleted the flatten-flow-bench branch December 26, 2019 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

@ndkoval ndkoval ndkoval approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@fmixing @qwwdfsad @ndkoval