Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update example Android apps toolchain (AGP 3.5.0, AndroidX) #1511

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

elizarov
Copy link
Contributor

@elizarov elizarov commented Sep 5, 2019

  • Gradle 5.4.1
  • AGP 3.5.0
  • Migrated to AndroidX
  • Updated versions of all dependencies to the most recent ones
  • Removed proguard rules

* Gradle 5.4.1
* AGP 3.5.0
* Migrated to AndroidX
* Updated versions of all dependencies to the most recent ones
* Removed proguard rules
@elizarov elizarov merged commit 0bef2b9 into develop Sep 5, 2019
@elizarov elizarov deleted the androidx branch September 5, 2019 10:00
@KaiyuanZhao
Copy link

hi @elizarov
ui/kotlinx-coroutines-android/build.gradle is still using com.android.support:support-annotations:$android_support_version

@elizarov
Copy link
Contributor Author

@KaiyuanZhao what should it use instead?

@KaiyuanZhao
Copy link

@elizarov use androidx.annotation:annotation instead of support. This is the full mapping

@elizarov
Copy link
Contributor Author

Tried it. Cannot find androidx.annotation:annotation artifact in any of the repositories we are using in our build (including a google repo).

@KaiyuanZhao
Copy link

@elizarov Did you add version after annotation? The full dependency notation is androidx.annotation:annotation:1.1.0

@KaiyuanZhao
Copy link

@elizarov Androidx annotation document is in this link. And this artifact is in google repo.

@elizarov
Copy link
Contributor Author

Thanks. See #1932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants