Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect missing awaitClose calls in callbackFlow and close channel wit… #1771

Merged
merged 2 commits into from
Feb 13, 2020

Conversation

qwwdfsad
Copy link
Member

…h a proper diagnostic exception

Fixes #1762
Fixes #1770

@qwwdfsad qwwdfsad requested a review from elizarov January 20, 2020 15:38
@qwwdfsad qwwdfsad marked this pull request as ready for review January 29, 2020 10:26
@qwwdfsad qwwdfsad requested a review from elizarov January 29, 2020 10:26
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done.

@qwwdfsad qwwdfsad merged commit 4aa3880 into develop Feb 13, 2020
@qwwdfsad qwwdfsad deleted the callback-flow branch February 13, 2020 12:43
@mhernand40
Copy link

Any chance this would end up fixing tfcporciuncula/flow-preferences#1? Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants