Implement ObservableValue<T>.asFlow() #1789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
suggested changes
Feb 11, 2020
ui/kotlinx-coroutines-javafx/test/JavaFxObservableAsFlowTest.kt
Outdated
Show resolved
Hide resolved
dkhalanskyjb
force-pushed
the
ObservableValue.asFlow
branch
from
81e829b to
897fefa
Compare
dkhalanskyjb
commented
Feb 13, 2020
qwwdfsad
suggested changes
Feb 21, 2020
ui/kotlinx-coroutines-javafx/test/JavaFxObservableAsFlowTest.kt
Outdated
Show resolved
Hide resolved
|
Please, rebase all the changes on current develop |
dkhalanskyjb
force-pushed
the
ObservableValue.asFlow
branch
from
485e7c3 to
0673361
Compare
qwwdfsad
suggested changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #1695
It seems there is no way to implement this for
Observableas it doesn't even expose the type of the observable value.