Skip to content

Conversation

@MariusVolkhart
Copy link
Contributor

No description provided.

@MariusVolkhart MariusVolkhart marked this pull request as ready for review February 10, 2020 22:57
@elizarov
Copy link
Contributor

Thanks! Good addition.

* List of modules in this document.
* List of modules in top-level [`settings.gradle`](../settings.gradle).
* List of modules at the root of documentation site in [`site/docs/index.md`](../site/docs/index.md).
* List of integrations in the root [README.md](../README.md)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: should end the sentence with comma.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elizarov I've made a change, but used a period rather than a comma, since the surrounding code used the periods as well. If you'd still like a comma, I'm happy to use that instead.

Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Very good.

@elizarov elizarov merged commit 1ed6fcc into Kotlin:develop Feb 13, 2020
@MariusVolkhart MariusVolkhart deleted the mv/integrationDocs branch February 19, 2020 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants