Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed extra non working SharedImmutable annotations #1892

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Removed extra non working SharedImmutable annotations #1892

merged 1 commit into from
Mar 31, 2020

Conversation

LepilkinaElena
Copy link

No description provided.

@LepilkinaElena LepilkinaElena requested a review from qwwdfsad March 31, 2020 10:03
@elizarov
Copy link
Contributor

Can you, please, comment on why the are non-working and can be removed?

@LepilkinaElena
Copy link
Author

Due to documentation https://kotlinlang.org/api/latest/jvm/stdlib/kotlin.native.concurrent/-shared-immutable/ @SharedImmutable is applicable only to top level objects/variables. It was just ignored before, now we added FE checkers and compiler fails.

@qwwdfsad qwwdfsad merged commit a3384a8 into master Mar 31, 2020
@qwwdfsad qwwdfsad deleted the fix_shared_immutable branch March 31, 2020 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@LepilkinaElena @elizarov @qwwdfsad