-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mention that the copied exception's message must be like the original #1931
Conversation
I am not sure such a strong wording is really needed. Nothing is going to break inside coroutines machinery is the copied exception message is different from the original, so an emphasis on "must" does not seem to be warranted here. I think it is better to rephrase it as a recommendation. |
I'm not married to the wording at all here. kotlinx.coroutines/kotlinx-coroutines-core/jvm/src/internal/StackTraceRecovery.kt Line 70 in d7de5f5
|
Good point. That should be added to the docs. That is, the explanation should mentation that the same message is a prerequisite for the stack recovery mechanism. |
Exactly :) |
Should I close this MR and open an issue instead or what would you prefer? |
It just needs a bit rephrasing and clarification on why the same message is needed. No need to close PR. It can be amended. |
…age identity in debugging.md Addresses #1931
…age identity in debugging.md Addresses #1931
…age identity in debugging.md Addresses Kotlin#1931
Just a quick fly-by PR as a suggestion on including this information.