Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix logic that determines future removal for scheduled executors #1995

Merged
merged 1 commit into from
May 7, 2020

Conversation

elizarov
Copy link
Contributor

@elizarov elizarov commented May 6, 2020

I've failed to write a reliable test here. See also #571

Fixes #1992

I've failed to write a reliable test here. See also #571

Fixes #1992
@elizarov elizarov requested a review from qwwdfsad May 6, 2020 12:26
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A good example of "If it ain't tested, it doesn't work" :(

@elizarov elizarov merged commit 5ecebe1 into develop May 7, 2020
@elizarov elizarov deleted the scheduled-executor-remove-future-fix branch May 7, 2020 13:57
recheej pushed a commit to recheej/kotlinx.coroutines that referenced this pull request Dec 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants