Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix toString representation of JobListenableFuture #2497

Closed
wants to merge 1 commit into from
Closed

Fix toString representation of JobListenableFuture #2497

wants to merge 1 commit into from

Conversation

vadimsemenov
Copy link
Contributor

Also add tests for toString.
I've created a new test file but happy to move tests into the main test file if that's preferable.

@qwwdfsad qwwdfsad changed the base branch from develop to pr/2422 January 27, 2021 13:35
@qwwdfsad qwwdfsad self-requested a review January 27, 2021 13:35
qwwdfsad
qwwdfsad approved these changes Jan 27, 2021
View reviewed changes
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!
Merged manually into PR 2422

@qwwdfsad qwwdfsad closed this Jan 27, 2021
@vadimsemenov vadimsemenov deleted the lf-tostring branch July 23, 2021 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vadimsemenov @qwwdfsad