Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly cancel ChannelCoroutine when the channel was closed or cance… #2507

Merged
merged 1 commit into from
Jan 29, 2021
Merged

Properly cancel ChannelCoroutine when the channel was closed or cance… #2507

merged 1 commit into from
Jan 29, 2021

Conversation

qwwdfsad
Copy link
Member

…lled

Fixes #2506

elizarov
elizarov approved these changes Jan 29, 2021
View reviewed changes
Copy link
Contributor

@elizarov elizarov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice.

@qwwdfsad qwwdfsad marked this pull request as ready for review January 29, 2021 15:17
@qwwdfsad qwwdfsad merged commit 7061cc2 into develop Jan 29, 2021
@qwwdfsad qwwdfsad deleted the cancel-channel-coroutine branch January 29, 2021 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elizarov elizarov elizarov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @elizarov