Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make releaseInterceptedContinuation final #2785

Merged
merged 2 commits into from
Jun 23, 2021
Merged

Make releaseInterceptedContinuation final #2785

merged 2 commits into from
Jun 23, 2021

Conversation

qwwdfsad
Copy link
Member 

* CoroutineDispatcher is internal for implementation and always has been
* Overriding this method may lead to memory leaks in parent coroutines and is considered dangerous

@qwwdfsad
Make releaseInterceptedContinuation final
52f5fdd 
    * CoroutineDispatcher is internal for implementation and always has been
    * Overriding this method may lead to memory leaks in parent coroutines and is considered dangerous
@qwwdfsad qwwdfsad requested a review from dkhalanskyjb June 22, 2021 15:22
@qwwdfsad qwwdfsad merged commit a9e2f0b into develop Jun 23, 2021
@qwwdfsad qwwdfsad deleted the final-release-intercepted branch June 23, 2021 08:37
pablobaxter pushed a commit to pablobaxter/kotlinx.coroutines that referenced this pull request Sep 14, 2022
@qwwdfsad @pablobaxter
Make releaseInterceptedContinuation final (Kotlin#2785)
b6ff228 
* Make releaseInterceptedContinuation final
* CoroutineDispatcher is internal for implementation and always has been
* Overriding this method may lead to memory leaks in parent coroutines and is considered dangerous
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @dkhalanskyjb