Pr/2528 #2786
Merged
Pr/2528 #2786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t via passed in CancellationTokenSource
* Documentation improvement
* Reduced allocation pressure
| deferred.cancel() | ||
| } else { | ||
| @Suppress("UNCHECKED_CAST") | ||
| deferred.complete(this.result as T) |
There was a problem hiding this comment.
Why is this. needed?
There was a problem hiding this comment.
Not really needed, seems to be a leftover
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
dkhalanskyjb
approved these changes
Jun 24, 2021
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
…Kotlin#2786) * Support bi-directional cancellation for Task.asDeferred and Task.await via passed in CancellationTokenSource Fixes Kotlin#2527 Co-authored-by: Alex Vanyo <vanyoalex@gmail.com> Co-authored-by: dkhalanskyjb <52952525+dkhalanskyjb@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a redacted mirror of #2528.
I've reviewed and accepted it, but it would be nice to have a second pair of eyes here in case I missed something during the course of multiple review iterations