-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display artificial stack frames as calls to functions instead of text #3073
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please elaborate what is the latest IDEA version that do not support this change and when we've dropped the support of such version?
This change is supported since 212. The support for 211 stopped with 2021.1.3 coming out, which was this summer: https://blog.jetbrains.com/idea/2021/06/intellij-idea-2021-1-3/ |
Could you please figure out whether we are allowed to merge this change? |
The last Kotlin Plugin version to support IDEA 211 was 1.6.21. So, I think we're good to go. |
e8cc227
to
e5c9881
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
A few obligatory things prior to merging:
- Please check that coroutines debugger in IDE works with this change
- Please link here the issue in KTIJ that supports this new behaviour, so we can track the change back to its roots if there is need to
|
e5c9881
to
9486e08
Compare
That's a bummer, could you please ask Nikita to do so and to link the commit with the change in IDEA to it? |
Seems like my previous message got lost (?), though the labels edit didn't. Changes are good to go |
Here's the older comment: #2291 (comment) No harm in repeating this, I think. |
9486e08
to
cf7e4c5
Compare
Originally implemented in #2461. I just cherry-picked it and made sure the project builds.
Fixes #2291