Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display artificial stack frames as calls to functions instead of text #3073

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

dkhalanskyjb
Copy link
Collaborator

Originally implemented in #2461. I just cherry-picked it and made sure the project builds.

Fixes #2291

@dkhalanskyjb dkhalanskyjb requested a review from qwwdfsad December 8, 2021 11:09
Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please elaborate what is the latest IDEA version that do not support this change and when we've dropped the support of such version?

@dkhalanskyjb
Copy link
Collaborator Author

This change is supported since 212. The support for 211 stopped with 2021.1.3 coming out, which was this summer: https://blog.jetbrains.com/idea/2021/06/intellij-idea-2021-1-3/

@qwwdfsad
Copy link
Collaborator

qwwdfsad commented Sep 8, 2022

Could you please figure out whether we are allowed to merge this change?

@dkhalanskyjb
Copy link
Collaborator Author

The last Kotlin Plugin version to support IDEA 211 was 1.6.21. So, I think we're good to go.

Copy link
Collaborator

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

A few obligatory things prior to merging:

  • Please check that coroutines debugger in IDE works with this change
  • Please link here the issue in KTIJ that supports this new behaviour, so we can track the change back to its roots if there is need to

@dkhalanskyjb
Copy link
Collaborator Author

  1. Both navigation to the stub symbols and the debugger work as intended with the latest versions of everything and this change.
  2. I don't think such an issue was ever filed.

@dkhalanskyjb dkhalanskyjb force-pushed the prettier-stack-traces branch from e5c9881 to 9486e08 Compare October 14, 2022 08:20
@qwwdfsad
Copy link
Collaborator

I don't think such an issue was ever filed.

That's a bummer, could you please ask Nikita to do so and to link the commit with the change in IDEA to it?

@qwwdfsad
Copy link
Collaborator

qwwdfsad commented Oct 20, 2022

Seems like my previous message got lost (?), though the labels edit didn't.
Anyway, all the required commits are in place in all our supported platforms:
657936acb69fbbc59a88e1b7e799f49e81d9f162 (for Ultimate repo) and
JetBrains/intellij-community@fd29488

Changes are good to go

@dkhalanskyjb
Copy link
Collaborator Author

Here's the older comment: #2291 (comment) No harm in repeating this, I think.

@dkhalanskyjb dkhalanskyjb force-pushed the prettier-stack-traces branch from 9486e08 to cf7e4c5 Compare October 20, 2022 14:28
@dkhalanskyjb dkhalanskyjb merged commit 0bb8ee8 into develop Oct 20, 2022
@dkhalanskyjb dkhalanskyjb deleted the prettier-stack-traces branch October 20, 2022 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants