Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 1.7.0 #3740

Merged
merged 10 commits into from
May 5, 2023
Merged

Version 1.7.0 #3740

merged 10 commits into from
May 5, 2023

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented May 5, 2023

No description provided.

ndkoval and others added 8 commits April 19, 2023 16:24
Signed-off-by: Nikita Koval <ndkoval@ya.ru>
And remove usages of JvmDefault, which is going to be deprecated with
error in KT-54746.
#3723)

We do rely on java.util.concurrent primitives for rendezvous in tests,
but we cannot rely on their internal stacktraces in tests, thus filtering them out from test data.

Otherwise, tests outcome depends on the underlying JDK version

Fixes #3700
…3733)

With #3449, the unrelated uncaught exceptions can also be caught in
this manner.
#3731)

* Properly recover exceptions when they are constructed from 'Throwable(cause)' constructor.

And restore the original behaviour. After #1631 this constructor's recovery mechanism was broken because 'Throwable(cause)' changes the message to be equal to 'cause.toString()', which isn't equal to the original message.

Also, make reflective constructor choice undependable from source-code order

Fixes #3714
The solution for #1205 may be undesirable for those who already
have their own solution, like setting the default exception
handlers. In this case, there's a usability issue without the
corresponding benefit: instead of all tests being ran and the
exceptions from them being reported, unrelated tests may fail,
making looking for problems more difficult.

This is probably a very rare issue, so we don't provide public API
for that, instead introducing a need-to-know internal variable.
@qwwdfsad qwwdfsad requested a review from dkhalanskyjb May 5, 2023 10:09
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done!

ndkoval and others added 2 commits May 5, 2023 15:18
@qwwdfsad
Copy link
Collaborator Author

qwwdfsad commented May 5, 2023

image

FTR, this one is clickable and shows the diff

@qwwdfsad qwwdfsad merged commit 2e92d58 into master May 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants