-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed visibility of atomic properties as required by the new JVM compiler plugin #3808
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't forget to put
kotlin-merge-blocker
I'll add the link to this issue at atomicfu GH before merge: Kotlin/kotlinx-atomicfu#322 |
Should we put |
a425482
to
9f4485e
Compare
Yes, on everything that breaks aggregate. This is also a signal for release manager to proceed with rebase, see https://jetbrains.team/p/kti/repositories/kotlin-teamcity-build/files/.teamcity/common/buildtypes/tests/userprojects/mainAggregate/README.md |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but please merge only after every step from the aggregate process is fulfilled
Ok, thanks! Though this should not break the aggregate build. |
Requested also KT issue as changes are done in Kotlin master. |
Here is the YT issue for all the changes: https://youtrack.jetbrains.com/issue/KT-60528/Updates-for-JVM-IR-backend-of-kotlin-atomicfu-compiler-plugin Mentioned it in the commit message |
…e or internal The new atomicfu JVM compiler plugin (since 1.9.20) will explicitly require atomic properties to be private or internal (or to be members of private or internal classes). See: Kotlin/kotlinx-atomicfu#322 YT issue: KT-60528
9f4485e
to
eeba1be
Compare
The new atomicfu JVM compiler plugin (since 1.9.20) will explicitly require atomic properties to be private or internal (or be members of private or internal classes). These fixes are required now in the aggregate build to merge changes in the new jvm plugin, so this commit is added to develop first.