Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gradle Dokka configuration to make sure (source) button is visible in all API docs #3960

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Nov 30, 2023

Fully fixes #3929

After #3930 was merged there is no more (source) for MPP modules (core and test) because they are using different convention for sources.

In this PR dokka configuration for MPP modules is aligned with how sources are configured + it now doesn't use hardcoded names of sourceSets (previously, f.e. jdk8 and concurrent were not configured, and so no (source) link were there)

BTW, I found, that there is some issue, that functions which are in jdk8 can't resolve classes from common (in this case there should be Flow:

Screenshot image
I will try to address this in another PR later, or create an issue at Dokka side, depending on the results of investigation

@whyoleg whyoleg self-assigned this Nov 30, 2023
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add "source" button to API docs
2 participants