Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linuxArm64 native target #213

Merged
merged 1 commit into from
Jun 5, 2023
Merged

Conversation

bcmedeiros
Copy link
Contributor

@bcmedeiros bcmedeiros commented Apr 29, 2023

I'm trying to work towards https://youtrack.jetbrains.com/issue/KTOR-5753 and bumped into

No matching variant of org.jetbrains.kotlinx:kotlinx-html:0.8.1 was found.

With this PR, building on linux x86-64 seems to work fine and cross-compile to arm64.

Let me know if there is something else I can help with.

@bcmedeiros
Copy link
Contributor Author

Hey, is there anyone available to review this?

@e5l e5l self-requested a review June 5, 2023 15:02
Copy link
Member

@e5l e5l left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@e5l e5l merged commit 003ca00 into Kotlin:master Jun 5, 2023
@bcmedeiros
Copy link
Contributor Author

Thanks, @e5l! Any changes of a release soon? :D

@e5l
Copy link
Member

e5l commented Jun 5, 2023

Hey, @bcmedeiros. It will be released in approx 2 weeks

@hfhbd
Copy link
Contributor

hfhbd commented Jun 13, 2023

Just to make it sure: Do you plan to release a new version of kotlinx-html before Ktor 2.3.2 to also include ktorio/ktor#3587 in Ktor 2.3.2?

@bcmedeiros
Copy link
Contributor Author

I can update ktorio/ktor#3587 and get it ready to be reviewed and merged as soon as we have a release here, it's the only pending issue.

@hfhbd
Copy link
Contributor

hfhbd commented Jun 13, 2023

Yes, it was a question to @e5l or the Ktor team.

@e5l
Copy link
Member

e5l commented Jun 14, 2023

@bcmedeiros Yep

@bcmedeiros
Copy link
Contributor Author

Hey, @bcmedeiros. It will be released in approx 2 weeks

@e5l it's been (almost) 2 weeks already, any idea when it's going to be released? no pressure, just wanted to plan myself to finish the ktor PR as soon as this is released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants