Replace custom time handling with kotlin.time.TimeSource #260

hfhbd · 2024-02-10T14:35:47Z

This is a binary breaking change.

The current implementation of TagConsumer.measureTime uses a custom time implementation. With Kotlin 1.9, TimeSource is finally stable so we can use it instead. This also allows us to use TimedValue.

Another advantage: The standard lib also provides a TimeSource.Monotonic for WASI, so adding WASI support removes the need to implement currentTimeMillis by ourself.

hfhbd · 2024-02-10T14:36:42Z

src/commonMain/kotlin/measure-consumer.kt


-data class TimedResult<T>(val result: T, val time: Long)
+val <O : Appendable> TimedValue<O>.out: O


What's the reason for this extension? 🤔 You can call result/value directly.

src/commonMain/kotlin/trace-consumer.kt

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [org.postgresql:postgresql](https://jdbc.postgresql.org) ([source](https://github.com/pgjdbc/pgjdbc)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `42.7.4` -> `42.7.5` | | [org.jetbrains.kotlinx:kotlinx-html-jvm](https://github.com/Kotlin/kotlinx.html) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `0.11.0` -> `0.12.0` | | [org.jooq:jooq](http://www.jooq.org) ([source](https://github.com/jOOQ/jOOQ)) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `3.18.24` -> `3.18.25` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.0` -> `1.45.1` | | [com.datadoghq:dd-trace-ot](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.45.0` -> `1.45.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.29.51` -> `2.29.52` | --- ### Release Notes <details> <summary>Kotlin/kotlinx.html (org.jetbrains.kotlinx:kotlinx-html-jvm)</summary> ### [`v0.12.0`](https://github.com/Kotlin/kotlinx.html/releases/tag/0.12.0) #### What's Changed - Added HTML templates by [@e5l](https://github.com/e5l) in Kotlin/kotlinx.html#255 - Replace usage js with WasmJs in README.md by [@e5l](https://github.com/e5l) in Kotlin/kotlinx.html#257 - Improve Gradle build logic by [@hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#258 - Use kotlin.test everywhere by [@hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#259 - Replace custom time handling with kotlin.time.TimeSource by [@hfhbd](https://github.com/hfhbd) in Kotlin/kotlinx.html#260 - Add contracts to node append and tag declaration calls by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#264 - Added "as" attribute for Link tag by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#265 - Added IE-specific values for textarea wrap attribute by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#266 - Reducing the amount of compiler warnings in gen-enums.kt by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#269 - Added "referrerpolicy", "media", and "download" attributes for "a" tag by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#270 - Fixing typo in area attribute by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#271 - Updating Github Actions and enabling cross-platform testing by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#272 - Improving Tag Generation by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#274 - Added srcset attribute to "source" tag by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#273 - Added "auto" value for "dir" attribute by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#275 - Upgrading Kotlin to 2.0.0 by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#282 - Reworked the validation of attribute names to better correspond to HTML standards by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#276 - Make attribute traits inheritable by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#280 - Using correct string type for input attribute "autocomplete" by [@severn-everett](https://github.com/severn-everett) in Kotlin/kotlinx.html#278 - Support android native targets and wasm-wasi by [@whyoleg](https://github.com/whyoleg) in Kotlin/kotlinx.html#288 #### New Contributors - [@hfhbd](https://github.com/hfhbd) made their first contribution in Kotlin/kotlinx.html#258 - [@whyoleg](https://github.com/whyoleg) made their first contribution in Kotlin/kotlinx.html#288 **Full Changelog**: Kotlin/kotlinx.html@0.11.0...0.12.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 3e633633f6599555fd8c75c49d915b16242cac27

hfhbd commented Feb 10, 2024

View reviewed changes

src/commonMain/kotlin/trace-consumer.kt Outdated Show resolved Hide resolved

e5l requested changes Feb 20, 2024

View reviewed changes

src/commonMain/kotlin/trace-consumer.kt Outdated Show resolved Hide resolved

src/commonMain/kotlin/trace-consumer.kt Outdated Show resolved Hide resolved

hfhbd and others added 3 commits February 20, 2024 16:05

Replace custom time handling with kotlin.time.TimeSource

d0b5960

Use hashcode

f5a8ee1

Merge branch 'master' into kotlin.time

b4721ad

e5l merged commit f1b51c6 into Kotlin:master Feb 21, 2024
1 check passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace custom time handling with kotlin.time.TimeSource #260

Replace custom time handling with kotlin.time.TimeSource #260

hfhbd commented Feb 10, 2024 •

edited

Loading

hfhbd Feb 10, 2024 •

edited

Loading


		data class TimedResult<T>(val result: T, val time: Long)
		val <O : Appendable> TimedValue<O>.out: O

Replace custom time handling with kotlin.time.TimeSource #260

Replace custom time handling with kotlin.time.TimeSource #260

Conversation

hfhbd commented Feb 10, 2024 • edited Loading

hfhbd Feb 10, 2024 • edited Loading

Choose a reason for hiding this comment

hfhbd commented Feb 10, 2024 •

edited

Loading

hfhbd Feb 10, 2024 •

edited

Loading