Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deserialization of float and double types in CBOR #1112

Merged
merged 1 commit into from
Oct 21, 2020
Merged

Fix deserialization of float and double types in CBOR #1112

merged 1 commit into from
Oct 21, 2020

Conversation

shanshin
Copy link
Contributor

@shanshin shanshin commented Oct 1, 2020

  • add support of half-precision floating-point values for double and float decoders
  • double decoder now can read float values
  • write tests for boundary and other values

sandwwraith
sandwwraith requested changes Oct 5, 2020
View reviewed changes
Copy link
Member

@sandwwraith sandwwraith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I haven't dug enough into the differences of HFP algorithms to determine which one is better. I can return to them later if you wish. Right now, the only questionable part for me in current implementation is the loop, but it is not something critical.

formats/cbor/commonMain/src/kotlinx/serialization/cbor/internal/Encoding.kt Outdated Show resolved Hide resolved
formats/cbor/commonMain/src/kotlinx/serialization/cbor/internal/Encoding.kt Outdated Show resolved Hide resolved
formats/cbor/commonMain/src/kotlinx/serialization/cbor/internal/Encoding.kt Outdated Show resolved Hide resolved
formats/cbor/commonMain/src/kotlinx/serialization/cbor/internal/Encoding.kt Outdated Show resolved Hide resolved
formats/cbor/jvmTest/src/kotlinx/serialization/cbor/CborCompatibilityTest.kt Outdated Show resolved Hide resolved
@shanshin
Fix deserialization of float and double types in CBOR (#1034)
8302b96 
  * add support of half-precision floating-point values for double and float decoders
  * double decoder now can read float values
  * write tests for boundary and other values
@sandwwraith sandwwraith merged commit d58afee into dev Oct 21, 2020
@sandwwraith sandwwraith deleted the cbor-half-precision-1034 branch October 21, 2020 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad left review comments

@twyatt twyatt twyatt left review comments

@sandwwraith sandwwraith sandwwraith approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shanshin @twyatt @qwwdfsad @sandwwraith