Fix dynamic serialization for nullable values #1199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c dynamic serialization
…ic dynamic serialization, and support encodeDefaults
ankushg
commented
Nov 12, 2020
Comment on lines
+143
to
+148
| encodeAndDecode(Sealed.serializer(), nullChild, objectJson) { | ||
| assertEquals("nullable_child", this.type) | ||
| assertEquals(nullChild.nullable, this.nullable) | ||
| assertEquals(nullChild.intField, this.intField) | ||
| assertEquals(3, fieldsCount(this)) | ||
| } |
There was a problem hiding this comment.
This specific test is what was failing before.
It works fine for non-null values and/or array-based serialization, but was throwing a TypeError: Cannot convert undefined or null to object when it tried js("Object").keys(null) with object-based serialization
|
@shanshin This is my first contribution into |
shanshin
reviewed
Nov 19, 2020
formats/json/jsTest/src/kotlinx/serialization/json/DynamicPolymorphismTest.kt
Show resolved
Hide resolved
formats/json/jsTest/src/kotlinx/serialization/json/DynamicPolymorphismTest.kt
Show resolved
Hide resolved
formats/json/jsTest/src/kotlinx/serialization/json/DynamicPolymorphismTest.kt
Outdated
Show resolved
Hide resolved
sandwwraith
approved these changes
Nov 20, 2020
formats/json/jsTest/src/kotlinx/serialization/json/DynamicPolymorphismTest.kt
Show resolved
Hide resolved
Co-authored-by: Leonid Startsev <sandwwraith@users.noreply.github.com>
shanshin
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1198
Also adds tests to verify that other potential edge cases work as intended (empty lists, default parameters)
Updates kdoc comments to remove outdated disclaimer that polymorphism is not supported.