Experimental support for inline classes #1244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanshin
approved these changes
Dec 15, 2020
formats/json/commonTest/src/kotlinx/serialization/features/inline/InlineClassesCompleteTest.kt
Show resolved
Hide resolved
sandwwraith
force-pushed
the
inline_classes
branch
from
bcd0b93
to
e5bdea8
Compare
qwwdfsad
requested changes
Jan 19, 2021
core/commonMain/src/kotlinx/serialization/descriptors/SerialDescriptor.kt
Outdated
Show resolved
Hide resolved
core/commonMain/src/kotlinx/serialization/descriptors/SerialDescriptor.kt
Outdated
Show resolved
Hide resolved
core/commonMain/src/kotlinx/serialization/internal/InlineClassDescriptor.kt
Outdated
Show resolved
Hide resolved
core/commonMain/src/kotlinx/serialization/internal/PluginGeneratedSerialDescriptor.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonEncoder.kt
Show resolved
Hide resolved
sandwwraith
force-pushed
the
inline_classes
branch
from
791f222
to
38f5b3b
Compare
sandwwraith
commented
Jan 20, 2021
|
|
||
| ```kotlin | ||
| object UIDSerializer: KSerializer<UID> { | ||
| override val descriptor = UInt.serializer().descriptor |
There was a problem hiding this comment.
Here we lack analogue of PrimitiveClassDescriptor
qwwdfsad
requested changes
Jan 26, 2021
core/commonMain/src/kotlinx/serialization/internal/EmptyEncoder.kt
Outdated
Show resolved
Hide resolved
core/commonMain/src/kotlinx/serialization/internal/EmptyEncoder.kt
Outdated
Show resolved
Hide resolved
| import kotlin.test.* | ||
|
|
||
| @Serializable | ||
| data class SimpleContainerForUInt(val i: UInt) |
There was a problem hiding this comment.
These classes can be moved into InlineClassesTest, can't they?
There was a problem hiding this comment.
'Inline classes are only allowed on top level' says Kotlin compiler
formats/json/commonTest/src/kotlinx/serialization/features/inline/InlineClassesCompleteTest.kt
Show resolved
Hide resolved
formats/json/commonTest/src/kotlinx/serialization/features/inline/EncodeInlineElementTest.kt
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/TreeJsonEncoder.kt
Outdated
Show resolved
Hide resolved
Serializer for UInt, handling UInt in JSON
Support all unsigned types for streaming and tree Json (excecpt for ULong)
Bump version
…not the source set
…l/TreeJsonEncoder.kt Co-authored-by: Vsevolod Tolstopyatov <qwwdfsad@gmail.com>
sandwwraith
force-pushed
the
inline_classes
branch
from
4e0268a
to
62cae74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Serializable inline classwith generated (requires 1.4.30 IR compiler) and custom serializers