Rewrite and restructure JSON parser #1343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Get rid of spontaneous lookahead * Spill fewer variables into object state * Optimize token and whitespaces reading * Separate fast and slow paths * Add optimistic key consumption optimization to leverage indexOf intrinsic * Improve exception messages in few places All tests except lenient boolean should pass Benchmark difference for throughput (Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz, libraries-linux-perf-unit-877): CitmBenchmark.decodeCitm diff +8% CoerceInputValuesBenchmark.testNonNullableCoercing diff +11% CoerceInputValuesBenchmark.testNonNullableRegular diff +5% CoerceInputValuesBenchmark.testNullableCoercing diff +7% CoerceInputValuesBenchmark.testNullableRegular diff +13% JacksonComparisonBenchmark.kotlinFromString diff +16% (noisy, JUT-dependable) TwitterBenchmark.parseTwitter diff +26% TwitterFeedBenchmark.parseTwitter diff +30%
qwwdfsad
force-pushed
the
json-performance
branch
from
18de55e to
9a0277a
Compare
qwwdfsad
force-pushed
the
json-performance
branch
4 times, most recently
from
7117dcd to
269d3d3
Compare
…ting over the source
qwwdfsad
force-pushed
the
json-performance
branch
from
269d3d3 to
e9d4d3e
Compare
…here they are not really necessary It gives solid 5-10% of throughpuut
qwwdfsad
force-pushed
the
json-performance
branch
from
003f59e to
9fd2412
Compare
qwwdfsad
force-pushed
the
json-performance
branch
6 times, most recently
from
01b907b to
aa4ae97
Compare
* Replace handrolled char-array with StringBuilder, tweak it here and there
* Always use optimistic path for strings
* Properly handle slow-path from the middle of a string
qwwdfsad
force-pushed
the
json-performance
branch
from
aa4ae97 to
9b97996
Compare
sandwwraith
reviewed
Feb 25, 2021
benchmark/src/jmh/kotlin/kotlinx/benchmarks/json/CoerceInputValuesBenchmark.kt
Show resolved
Hide resolved
benchmark/src/jmh/kotlin/kotlinx/benchmarks/json/PrimitiveValuesBenchmark.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/JsonElementSerializers.kt
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonReader.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonReader.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Outdated
Show resolved
Hide resolved
formats/json/jvmTest/src/kotlinx/serialization/json/GsonCompatibilityTest.kt
Show resolved
Hide resolved
* Better exception messages and hints
* Minor improvements
* More comments
sandwwraith
reviewed
Mar 3, 2021
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonReader.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonReader.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonReader.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonReader.kt
Outdated
Show resolved
Hide resolved
sandwwraith
approved these changes
Mar 4, 2021
EdwarDDay
reviewed
Mar 4, 2021
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Outdated
Show resolved
Hide resolved
# Conflicts: # benchmark/src/jmh/kotlin/kotlinx/benchmarks/json/TwitterBenchmark.kt
|
@qwwdfsad my app heavily utilize CPU - ~15% from all cores and more shows in Htop. Even worse on mobile devices. After your two PRs CPU usage was reduced to ~10%. It's awesome! Thank you for your findings! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Benchmark improvements for throughput (Intel(R) Core(TM) i7-6700 CPU @ 3.40GHz, libraries-linux-perf-unit-877):