Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix numeric overflow in JsonLexer #1367

Merged
merged 1 commit into from
Mar 12, 2021
Merged

Fix numeric overflow in JsonLexer #1367

merged 1 commit into from
Mar 12, 2021

Conversation

EdwarDDay
Copy link
Contributor

Before this fix 9223372036854775808 is read as -9223372036854775808.

@qwwdfsad qwwdfsad self-requested a review March 12, 2021 12:10
qwwdfsad
qwwdfsad approved these changes Mar 12, 2021
View reviewed changes
Copy link
Member

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha, sneaky Long.MIN_VALUE. Thanks for spotting!

@qwwdfsad qwwdfsad merged commit 0883e54 into Kotlin:dev Mar 12, 2021
@EdwarDDay EdwarDDay deleted the json-fix-numeric-overflow branch March 12, 2021 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EdwarDDay @qwwdfsad