Support for multiple alternative names during JSON parsing #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO: measure performance impact and decide whether this flag should be enabled by default (or should the feature be flagged at all) |
sandwwraith
force-pushed
the
alternate_names_2
branch
from
2853e69
to
558b260
Compare
qwwdfsad
requested changes
Apr 7, 2021
formats/json/commonTest/src/kotlinx/serialization/json/JsonCustomSerializersTest.kt
Outdated
Show resolved
Hide resolved
formats/json/commonTest/src/kotlinx/serialization/features/JsonAlternativeNamesTest.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/StreamingJsonDecoder.kt
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/JsonNames.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/JsonNames.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonLexer.kt
Show resolved
Hide resolved
sandwwraith
force-pushed
the
alternate_names_2
branch
from
d9255c6
to
575d789
Compare
Is there anyway I could help? |
qwwdfsad
approved these changes
Apr 14, 2021
benchmark/src/jmh/kotlin/kotlinx/benchmarks/model/MacroTwitter.kt
Outdated
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/TreeJsonDecoder.kt
Outdated
Show resolved
Hide resolved
formats/json/commonTest/src/kotlinx/serialization/test/TestingFramework.kt
Outdated
Show resolved
Hide resolved
via DescriptorSchemaCache internal mechanism with guide, docs, and samples. Stabilize .toString() for SerialClassDescImpl; because HashMaps on different platforms have different iteration order. Disable primary collision detection for optimization purposes. Add benchmarks on skipping unknown fields.
Migrate to 1.5.0-M2 to do so (because vararg in serialinfo requires IR)
sandwwraith
force-pushed
the
alternate_names_2
branch
from
9f9c9f2
to
416a527
Compare
|
@KevinBassaDevelopment Thanks for suggestion! I've already did some performance evaluations, and as a result, we concluded that this flag can be safely set to 'true' by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@JsonNamesannotationFixes #203