Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSON omit null #1535

Merged
merged 2 commits into from
Jul 30, 2021
Merged

JSON omit null #1535

merged 2 commits into from
Jul 30, 2021

Conversation

shanshin
Copy link
Contributor

@shanshin shanshin commented Jun 7, 2021 •
edited
Loading

benchmarks

+1.75%	k.b.json.CitmBenchmark.decodeCitm
+0.49%	k.b.json.CitmBenchmark.encodeCitm
-0.82%	k.b.json.CoerceInputValuesBenchmark.testNonNullableCoercing
-0.65%	k.b.json.CoerceInputValuesBenchmark.testNonNullableRegular
-1.89%	k.b.json.CoerceInputValuesBenchmark.testNullableCoercing
+1.22%	k.b.json.CoerceInputValuesBenchmark.testNullableRegular
+1.67%	k.b.json.JacksonComparisonBenchmark.jacksonFromString
+1.76%	k.b.json.JacksonComparisonBenchmark.jacksonSmallToString
-0.71%	k.b.json.JacksonComparisonBenchmark.jacksonToString
+4.49%	k.b.json.JacksonComparisonBenchmark.jacksonToStringWithEscapes
+3.07%	k.b.json.JacksonComparisonBenchmark.kotlinFromString
+0.53%	k.b.json.JacksonComparisonBenchmark.kotlinSmallToString
+4.46%	k.b.json.JacksonComparisonBenchmark.kotlinToString
+2.43%	k.b.json.JacksonComparisonBenchmark.kotlinToStringWithEscapes
+4.89%	k.b.json.PrimitiveValuesBenchmark.decodeBoolean
+0.74%	k.b.json.PrimitiveValuesBenchmark.decodeInt
+6.29%	k.b.json.PrimitiveValuesBenchmark.decodeLong
+1.36%	k.b.json.TwitterBenchmark.decodeTwitter
-0.55%	k.b.json.TwitterBenchmark.encodeTwitter
+3.65%	k.b.json.TwitterFeedBenchmark.decodeMicroTwitter
-1.54%	k.b.json.TwitterFeedBenchmark.decodeMicroTwitterNoAltNames
-0.52%	k.b.json.TwitterFeedBenchmark.decodeTwitter
-1.24%	k.b.json.TwitterFeedBenchmark.decodeTwitterNoAltNames
+1.30%	k.b.json.TwitterFeedBenchmark.encodeTwitter
+15.57%	k.b.protobuf.ProtoBaseline.fromBytes
-4.58%	k.b.protobuf.ProtoBaseline.fromBytesExplicit
+3.49%	k.b.protobuf.ProtoBaseline.toBytes
+3.03%	k.b.protobuf.ProtoBaseline.toBytesExplicit
-0.50%	k.b.protobuf.ProtoHuge.fromBytes130
-1.64%	k.b.protobuf.ProtoHuge.toBytes130
+1.51%	k.b.protobuf.ProtoListBenchmark.fromBytes
-3.79%	k.b.protobuf.ProtoListBenchmark.toBytes
-0.39%	k.b.protobuf.ProtoListLikeBenchmark.fromBytes
+1.45%	k.b.protobuf.ProtoListLikeBenchmark.toBytes

Using omitNull = true flag for JSON's with all fields filled can sometimes slow down performance and increase volatility:

  • TwitterBenchmark.decodeTwitterOmitNull vs TwitterBenchmark.decodeTwitter: -5% .. +1.5%
  • OmitNullBenchmark.decodeNoNullsWithOmit vs OmitNullBenchmark.decodeNoNulls: -4.5% .. -3%
  • OmitNullBenchmark.decodeNullsWithOmit vs OmitNullBenchmark.decodeNulls: -4.7% .. -1%

@shanshin shanshin requested review from qwwdfsad and sandwwraith June 7, 2021 14:38
@shanshin shanshin force-pushed the json-omit-null-195 branch from 8c697a5 to 0d1d32b Compare June 11, 2021 15:14
qwwdfsad
qwwdfsad suggested changes Jun 15, 2021
View reviewed changes
core/commonMain/src/kotlinx/serialization/internal/ElementMarker.kt Outdated Show resolved Hide resolved
core/commonMain/src/kotlinx/serialization/internal/ElementMarker.kt Show resolved Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonAbsenceReader.kt Outdated Show resolved Hide resolved
core/commonMain/src/kotlinx/serialization/internal/ElementMarker.kt Outdated Show resolved Hide resolved
core/commonMain/src/kotlinx/serialization/internal/ElementMarker.kt Outdated Show resolved Hide resolved
core/commonMain/src/kotlinx/serialization/internal/ElementMarker.kt Outdated Show resolved Hide resolved
core/commonMain/src/kotlinx/serialization/internal/ElementMarker.kt Outdated Show resolved Hide resolved
@shanshin shanshin force-pushed the json-omit-null-195 branch from 0d1d32b to 5897f6d Compare June 22, 2021 12:53
@shanshin shanshin requested review from qwwdfsad and sandwwraith June 22, 2021 14:44
@sandwwraith sandwwraith mentioned this pull request Jun 25, 2021
Closed
sandwwraith
sandwwraith reviewed Jun 25, 2021
View reviewed changes
benchmark/src/jmh/kotlin/kotlinx/benchmarks/json/ImplicitNullsBenchmark.kt Outdated Show resolved Hide resolved
benchmark/src/jmh/kotlin/kotlinx/benchmarks/json/TwitterBenchmark.kt Show resolved Hide resolved
core/commonMain/src/kotlinx/serialization/internal/ElementMarker.kt Outdated Show resolved Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/Json.kt Outdated Show resolved Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/Json.kt Outdated Show resolved Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/Json.kt Outdated Show resolved Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/Json.kt Outdated Show resolved Hide resolved
formats/json/commonTest/src/kotlinx/serialization/json/JsonImplicitNullsTest.kt Show resolved Hide resolved
formats/json/jsMain/src/kotlinx/serialization/json/internal/DynamicDecoders.kt Show resolved Hide resolved
formats/json/jsTest/src/kotlinx/serialization/json/JsonDynamicImplicitNullsTest.kt Show resolved Hide resolved
@shanshin shanshin force-pushed the json-omit-null-195 branch 2 times, most recently from aefa167 to 6867a38 Compare July 15, 2021 10:28
@shanshin shanshin force-pushed the json-omit-null-195 branch from 6867a38 to 8901505 Compare July 26, 2021 16:17
@qwwdfsad qwwdfsad mentioned this pull request Jul 29, 2021
Closed
qwwdfsad
qwwdfsad approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@qwwdfsad qwwdfsad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

Also filed #1619 for release 1.3

@shanshin shanshin merged commit 2048fac into dev Jul 30, 2021
@shanshin shanshin deleted the json-omit-null-195 branch July 30, 2021 12:49
@shanshin shanshin mentioned this pull request Aug 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandwwraith sandwwraith sandwwraith approved these changes

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shanshin @qwwdfsad @sandwwraith