Switch on deep recursive function when nested level of JS… #1596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ON is too deep Fixes #1594
|
This is a prototype and I do not expect it to be merged as is, this is rather a PR to evaluate the approach in general |
|
Huh, it seems that the recursive upper-bound should be lower for K/N targets |
elizarov
suggested changes
Jul 15, 2021
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonTreeReader.kt
Outdated
Show resolved
Hide resolved
formats/json/commonTest/src/kotlinx/serialization/json/JsonElementDecodingTest.kt
Show resolved
Hide resolved
qwwdfsad
changed the title
|
@sandwwraith ready to merge, PTAL |
sandwwraith
reviewed
Jul 19, 2021
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonTreeReader.kt
Show resolved
Hide resolved
elizarov
approved these changes
Jul 19, 2021
sandwwraith
approved these changes
Jul 19, 2021
woainikk
pushed a commit
that referenced
this pull request
Aug 12, 2021
* Switch on deep recursive function when the nested level of JSON is too deep Fixes #1594
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ON is too deep
Fixes #1594