Serializable meta-annotation #1678
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsinukov
force-pushed
the
rsinukov/meta-serializable
branch
from
e2cda39 to
a0936e3
Compare
rsinukov
force-pushed
the
rsinukov/meta-serializable
branch
from
a0936e3 to
0edaff7
Compare
|
Overall a good idea. There is one challenge, if you use a custom serializer it doesn't make sense to provide any other values for the annotation (custom serializers don't have access to generated descriptors - it is broken in many ways, but if they are generic even more). As an alternative, why not use: This provides the factory the opportunity to return the serializer needed for that specific type (and meta annotation). |
rsinukov
force-pushed
the
rsinukov/meta-serializable
branch
from
bd67d7f to
d2b3268
Compare
sandwwraith
reviewed
Jan 20, 2022
guide/test/MySerializable.kt
Outdated
| @MetaSerializable | ||
| @Target(AnnotationTarget.CLASS) | ||
| annotation class MySerializable( | ||
| @MetaSerializable.Serializer val with: KClass<out KSerializer<*>> = KSerializer::class, |
rsinukov
force-pushed
the
rsinukov/meta-serializable
branch
from
d2b3268 to
29806d0
Compare
|
Since JetBrains/kotlin#4583 goes to 1.7.0, I'll merge this when the corresponding release would be prepared. |
|
Transferred commit to #1979 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://youtrack.jetbrains.com/issue/KTOR-2704