Improved okio support #1982
Merged
Improved okio support #1982
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
shanshin
commented
Jul 6, 2022
shanshin
commented
- when encoding and decoding, only BufferedSink/BufferedSource are used to eliminate ambiguities
- at the end of encoding, emitCompleteSegments is called instead of flash for BufferedSink
- internal extension functions changed to @PublishedApi + internal
- when encoding and decoding, only BufferedSink/BufferedSource are used to eliminate ambiguities - at the end of encoding, emitCompleteSegments is called instead of flash for BufferedSink - internal extension functions changed to @PublishedApi + internal
JakeWharton
reviewed
Jul 6, 2022
formats/json-okio/commonMain/src/kotlinx/serialization/json/okio/internal/OkioJsonStreams.kt
Outdated
Show resolved
Hide resolved
sandwwraith
reviewed
Jul 8, 2022
formats/json-okio/commonMain/src/kotlinx/serialization/json/okio/OkioStreams.kt
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonStreams.kt
Show resolved
Hide resolved
formats/json/commonMain/src/kotlinx/serialization/json/internal/JsonStreams.kt
Outdated
Show resolved
Hide resolved
sandwwraith
reviewed
Jul 11, 2022
formats/json-okio/commonMain/src/kotlinx/serialization/json/okio/OkioStreams.kt
Show resolved
Hide resolved
sandwwraith
approved these changes
Jul 12, 2022
martinbonnin
added a commit
to martinbonnin/kotlinx.serialization
that referenced
this pull request
Jul 20, 2022
Follow up from Kotlin#1982. Since a `BufferedSink` is now required, no need to add this in the documentation.
Merged
sandwwraith
pushed a commit
that referenced
this pull request
Jul 21, 2022
Follow up from #1982. Since a `BufferedSink` is now required, no need to add this in the documentation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.